From fb1fed74f4781a7f6a1b4b90ff814b0d590b6a39 Mon Sep 17 00:00:00 2001 From: leopoldwang Date: Fri, 11 Feb 2022 21:49:30 +0000 Subject: [PATCH 1/4] Update repos.go --- github/repos.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repos.go b/github/repos.go index 42cd163678..0e41037125 100644 --- a/github/repos.go +++ b/github/repos.go @@ -945,7 +945,7 @@ type PullRequestReviewsEnforcementUpdate struct { // Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. Can be omitted. DismissStaleReviews *bool `json:"dismiss_stale_reviews,omitempty"` // RequireCodeOwnerReviews specifies if an approved review is required in pull requests including files with a designated code owner. - RequireCodeOwnerReviews bool `json:"require_code_owner_reviews,omitempty"` + RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"` // RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged. // Valid values are 1 - 6. RequiredApprovingReviewCount int `json:"required_approving_review_count"` From 92f17afe263883f09d2aef6198d9f02b64a09768 Mon Sep 17 00:00:00 2001 From: Leo Wang Date: Sat, 12 Feb 2022 10:41:02 +0000 Subject: [PATCH 2/4] regenerated required code --- github/github-accessors.go | 8 ++++++++ github/github-accessors_test.go | 10 ++++++++++ 2 files changed, 18 insertions(+) diff --git a/github/github-accessors.go b/github/github-accessors.go index 90b9233439..85c899c568 100644 --- a/github/github-accessors.go +++ b/github/github-accessors.go @@ -12636,6 +12636,14 @@ func (p *PullRequestReviewsEnforcementUpdate) GetDismissStaleReviews() bool { return *p.DismissStaleReviews } +// GetRequireCodeOwnerReviews returns the RequireCodeOwnerReviews field if it's non-nil, zero value otherwise. +func (p *PullRequestReviewsEnforcementUpdate) GetRequireCodeOwnerReviews() bool { + if p == nil || p.RequireCodeOwnerReviews == nil { + return false + } + return *p.RequireCodeOwnerReviews +} + // GetAction returns the Action field if it's non-nil, zero value otherwise. func (p *PullRequestTargetEvent) GetAction() string { if p == nil || p.Action == nil { diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go index df8754f518..63e31b5c9d 100644 --- a/github/github-accessors_test.go +++ b/github/github-accessors_test.go @@ -14716,6 +14716,16 @@ func TestPullRequestReviewsEnforcementUpdate_GetDismissStaleReviews(tt *testing. p.GetDismissStaleReviews() } +func TestPullRequestReviewsEnforcementUpdate_GetRequireCodeOwnerReviews(tt *testing.T) { + var zeroValue bool + p := &PullRequestReviewsEnforcementUpdate{RequireCodeOwnerReviews: &zeroValue} + p.GetRequireCodeOwnerReviews() + p = &PullRequestReviewsEnforcementUpdate{} + p.GetRequireCodeOwnerReviews() + p = nil + p.GetRequireCodeOwnerReviews() +} + func TestPullRequestTargetEvent_GetAction(tt *testing.T) { var zeroValue string p := &PullRequestTargetEvent{Action: &zeroValue} From 7a5d2dab24be70a7a3c049337c12820571aa4e36 Mon Sep 17 00:00:00 2001 From: Leo Wang Date: Sat, 12 Feb 2022 21:02:12 +0000 Subject: [PATCH 3/4] updated comments to match github rest api doc --- github/repos.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/github/repos.go b/github/repos.go index 0e41037125..6123493d94 100644 --- a/github/repos.go +++ b/github/repos.go @@ -944,10 +944,10 @@ type PullRequestReviewsEnforcementUpdate struct { DismissalRestrictionsRequest *DismissalRestrictionsRequest `json:"dismissal_restrictions,omitempty"` // Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. Can be omitted. DismissStaleReviews *bool `json:"dismiss_stale_reviews,omitempty"` - // RequireCodeOwnerReviews specifies if an approved review is required in pull requests including files with a designated code owner. + // RequireCodeOwnerReviews specifies if merging pull requests is blocked until code owners have reviewed. RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"` // RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged. - // Valid values are 1 - 6. + // Valid values are 1 - 6 or 0 to not require reviewers RequiredApprovingReviewCount int `json:"required_approving_review_count"` } From d11e2fd37cb8508507443b4026417dc6914a7512 Mon Sep 17 00:00:00 2001 From: leopoldwang Date: Sun, 13 Feb 2022 16:26:49 +0000 Subject: [PATCH 4/4] Update github/repos.go Added missing period. Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- github/repos.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repos.go b/github/repos.go index 6123493d94..2b1139b679 100644 --- a/github/repos.go +++ b/github/repos.go @@ -947,7 +947,7 @@ type PullRequestReviewsEnforcementUpdate struct { // RequireCodeOwnerReviews specifies if merging pull requests is blocked until code owners have reviewed. RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"` // RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged. - // Valid values are 1 - 6 or 0 to not require reviewers + // Valid values are 1 - 6 or 0 to not require reviewers. RequiredApprovingReviewCount int `json:"required_approving_review_count"` }