From 9cb69ccd33158c2243dce27c668a1086132c9aaf Mon Sep 17 00:00:00 2001 From: viqueen Date: Tue, 31 Oct 2023 09:02:01 +1100 Subject: [PATCH 1/2] [noissue] omit empty checks on RequiredStatusChecks --- github/repos.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repos.go b/github/repos.go index 60ff9b4134..a722e9d6ac 100644 --- a/github/repos.go +++ b/github/repos.go @@ -1055,7 +1055,7 @@ type RequiredStatusChecks struct { Contexts []string `json:"contexts,omitempty"` // The list of status checks to require in order to merge into this // branch. - Checks []*RequiredStatusCheck `json:"checks"` + Checks []*RequiredStatusCheck `json:"checks,omitempty"` ContextsURL *string `json:"contexts_url,omitempty"` URL *string `json:"url,omitempty"` } From 23d33dd2f752ec74c8664f40fbfa7aedcc8b8056 Mon Sep 17 00:00:00 2001 From: viqueen Date: Tue, 31 Oct 2023 13:47:13 +1100 Subject: [PATCH 2/2] [noissue] adjust the tests --- github/repos_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/github/repos_test.go b/github/repos_test.go index 7486e488fe..2bdc1b4289 100644 --- a/github/repos_test.go +++ b/github/repos_test.go @@ -1766,7 +1766,6 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T) input := &ProtectionRequest{ RequiredStatusChecks: &RequiredStatusChecks{ Strict: true, - Checks: []*RequiredStatusCheck{}, }, RequiredPullRequestReviews: &PullRequestReviewsEnforcementRequest{ DismissStaleReviews: true, @@ -1802,8 +1801,7 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T) fmt.Fprintf(w, `{ "required_status_checks":{ "strict":true, - "contexts":[], - "checks": [] + "contexts":[] }, "required_pull_request_reviews":{ "dismissal_restrictions":{ @@ -1847,7 +1845,6 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T) RequiredStatusChecks: &RequiredStatusChecks{ Strict: true, Contexts: []string{}, - Checks: []*RequiredStatusCheck{}, }, RequiredPullRequestReviews: &PullRequestReviewsEnforcement{ DismissStaleReviews: true,