Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common templates and move README content #1353

Merged
merged 5 commits into from Aug 20, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Aug 7, 2019

Fixes #1341
Fixes #1264
Fixes #1245

@chingor13 chingor13 requested a review from a team as a code owner August 7, 2019 00:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are autogenerated. Can we edit details in this repo?

.kokoro/continuous/dependencies.cfg Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@googleapis googleapis deleted a comment from raquellopez2112 Aug 12, 2019
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"electronic address" is perhaps overreaching. I think it's perfectly OK to note someone's Twitter handle, blog URL, or developer email, for example.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CODE_OF_CONDUCT is straight from OSPO.

@chingor13 chingor13 requested a review from kolea2 August 20, 2019 17:04
@@ -1,383 +1,29 @@
# Google APIs Client Library for Java

- [Library Maintenance](#maintenance)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this getting moved into other modules?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content all moved into the wiki. I migrated all the content from developers.google.com and it was too much for the README.

@chingor13 chingor13 merged commit 9d48f53 into googleapis:master Aug 20, 2019
@chingor13 chingor13 deleted the devsite-content branch August 20, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
4 participants