Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor Typings for Schema$InstanceAggregatedList #1383

Closed
david-cannady opened this issue Oct 9, 2018 · 1 comment · Fixed by googleapis/nodejs-googleapis-common#34
Closed

Poor Typings for Schema$InstanceAggregatedList #1383

david-cannady opened this issue Oct 9, 2018 · 1 comment · Fixed by googleapis/nodejs-googleapis-common#34
Assignees
@JustinBeckwith
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript

Comments

@david-cannady
Copy link

Environment details

  • OS: N/A
  • Node.js version: N/A
  • npm version: N/A
  • googleapis version: "34.0.0"

Steps to reproduce

None.
Schema$InstanceAggregatedList.items is defined as ?: any.
This should be something like ?: { [key: string]?: Schema$InstancesScopedList }.
The same is true for Schema$*.warning. It would be better to have those properly defined.
@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. TypeScript and removed triage me I really want to be triaged. labels Oct 10, 2018
@ajaaym ajaaym mentioned this issue Oct 30, 2018
Merged
3 tasks
@ajaaym
Copy link
Contributor

ajaaym commented Oct 30, 2018

@JustinBeckwith Can you please reopen this issue again as there is another change required in generator after googleapis-common is released with change

@ajaaym ajaaym mentioned this issue Nov 5, 2018
Merged
ajaaym added a commit to ajaaym/google-api-nodejs-client that referenced this issue Nov 9, 2018
@ajaaym
Fix googleapis#1383 Poor Typings for Schema
3491167
@ajaaym ajaaym mentioned this issue Nov 9, 2018
Merged
3 tasks
ajaaym added a commit to ajaaym/google-api-nodejs-client that referenced this issue Nov 9, 2018
@ajaaym
Fix googleapis#1383 Poor Typings for Schema
4fc391c
ajaaym added a commit to ajaaym/google-api-nodejs-client that referenced this issue Nov 13, 2018
@ajaaym
Fix googleapis#1383 Poor Typings for Schema
676429f
ajaaym added a commit that referenced this issue Nov 14, 2018
@ajaaym
Fix #1383 Poor Typings for Schema (#1433)
fd9eb79 
* Fix #1383 Poor Typings for Schema
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additionalProperties to SchemaItem ajaaym/nodejs-googleapis-common
3 participants
@JustinBeckwith @ajaaym @david-cannady