Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1374 Generator missing standard parameters #1390

Merged
merged 2 commits into from Oct 17, 2018
Merged

Fix for #1374 Generator missing standard parameters #1390

merged 2 commits into from Oct 17, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Oct 16, 2018 •
edited

Fixes #1374 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2018
@JustinBeckwith JustinBeckwith merged commit 16b912b into googleapis:master Oct 17, 2018
@JustinBeckwith
Copy link
Contributor

Thanks for the fix!

@ajaaym ajaaym mentioned this pull request Nov 5, 2018
Closed
@RebelTat RebelTat mentioned this pull request May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajaaym @JustinBeckwith @googlebot