Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use URL constructor in the samples #1424

Merged
merged 1 commit into from Nov 5, 2018
Merged

fix: use URL constructor in the samples #1424

merged 1 commit into from Nov 5, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Fixes the breaking tests on master.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2018
@JustinBeckwith JustinBeckwith requested review from ofrobots and a team November 2, 2018 17:56
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2018
@JustinBeckwith JustinBeckwith merged commit 1809e13 into googleapis:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinBeckwith @jkwlui @googlebot @kokoro-team