Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1383 Poor Typings for Schema #1433

Merged
merged 6 commits into from Nov 14, 2018
Merged

Fix #1383 Poor Typings for Schema #1433

merged 6 commits into from Nov 14, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Nov 9, 2018

Fixes #1383 Add typing information for object

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
@ajaaym ajaaym requested review from JustinBeckwith and a team November 9, 2018 22:23
@JustinBeckwith
Copy link
Contributor

Nice! Have you tried running npm run generate with this change, and ensured all the tests passed?

JustinBeckwith
JustinBeckwith approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming all test pass after running npm run generate on your machine :)

@ajaaym
Copy link
Contributor Author

ajaaym commented Nov 13, 2018

@JustinBeckwith Thanks for feedback. All test case are passing.

@ajaaym ajaaym merged commit fd9eb79 into googleapis:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajaaym @JustinBeckwith @googlebot