Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for repeated fields #1451

Merged
merged 1 commit into from Nov 19, 2018
Merged

feat: Add support for repeated fields #1451

merged 1 commit into from Nov 19, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Nov 19, 2018

Fixes #1266 Adds support for repeated fields

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@JustinBeckwith
Copy link
Contributor

Thanks! Generally LGTM - starting to think we should add something to the system tests to run the generator though. Can you verify you ran npm run generate, and that the resulting output passes all the tests?

@ajaaym
Copy link
Contributor Author

ajaaym commented Nov 19, 2018

@JustinBeckwith Yeah I ran below command and all runs fine.
npm run generate
npm run test
npm run system-test
npm run samples-test

I agree that we should have something to system tests to run the generator. Will create another PR for this.

@JustinBeckwith JustinBeckwith changed the title Fix #1266 Add support for repeated fields feat: Add support for repeated fields Nov 19, 2018
@JustinBeckwith JustinBeckwith merged commit 8d900f1 into googleapis:master Nov 19, 2018
@ajaaym ajaaym deleted the fix_1266 branch November 19, 2018 20:30
gcf-owl-bot bot added a commit that referenced this pull request Jun 7, 2022
@gcf-owl-bot
build(node): add new jsteam + enforce branches up-to-date (#1451)
3a92e33 
Source-Link: googleapis/synthtool@cd78529
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ddb19a6df6c1fa081bc99fb29658f306dd64668bc26f75d1353b28296f3a78e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajaaym @JustinBeckwith @googlebot