feat: generating webpackable packages #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
added
the
do not merge
googlebot
added
the
cla: yes
alexander-fenster
removed
the
do not merge
alexander-fenster
changed the title
|
@JustinBeckwith This is now ready for review! |
JustinBeckwith
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
LGTM w/nits. Have you run the generator to make sure the resulting output looks right? From a process perspective:
- Please run the generator against master, and submit a PR with any changes
- After that lands, let's land this PR
- Let's follow up with a PR that includes just the generated changes from this PR
3 tasks
|
This complicated process is exactly the reason why I suggest that generator should live outside of this library, being a devDependency :) #1554 shows the changes to all APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating small packages that are:
AuthPlusis re-exported fromgoogleapis-commonto make it available for users).