Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move context from namespace to class scope #1660

Merged
merged 1 commit into from Mar 28, 2019
Merged

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Mar 28, 2019

Fixes #1594. The context object was moved from the outer namespace of the template inside of the class. This ensures that differently scoped objects get their own context, which can have their own authentication provider.

This was broken in #1476. The affected versions are 36 => 39.

The fix should be in 40 when it is released.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #1660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1660   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files           2       2           
  Lines         267     267           
  Branches        2       2           
======================================
  Hits          263     263           
  Misses          4       4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73eab9b...e1b086f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth.setCredentials has side effects for all clients in the same event loop.
3 participants