Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module name to submodules #783

Merged
merged 3 commits into from Aug 8, 2019
Merged

add module name to submodules #783

merged 3 commits into from Aug 8, 2019

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Aug 8, 2019

@elharo elharo requested a review from chingor13 August 8, 2019 15:07
@elharo elharo requested a review from a team as a code owner August 8, 2019 15:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
@elharo elharo changed the title add module name to protobuf module add module name to submodules Aug 8, 2019
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we missed the google-http-client-xml artifact

@elharo
Copy link
Contributor Author

elharo commented Aug 8, 2019

done. @suztomo is working on a general check to find all the various artifacts across the GCP orbit that need this treatment. Foe some of them I think we'll have to fix split packages first.

@elharo
Copy link
Contributor Author

elharo commented Aug 8, 2019

@chingor13 chingor13 merged commit b1e9adc into master Aug 8, 2019
@chingor13 chingor13 deleted the module branch August 8, 2019 17:07
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
….92 (googleapis#783)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.appengine:appengine](https://cloud.google.com/appengine/docs/standard/java/javadoc/) ([source](http://svn.sonatype.org/spice/tags/oss-parent-4)) | `1.9.91` -> `1.9.92` | [![age](https://badges.renovateapi.com/packages/maven/com.google.appengine:appengine/1.9.92/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.appengine:appengine/1.9.92/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.appengine:appengine/1.9.92/compatibility-slim/1.9.91)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.appengine:appengine/1.9.92/confidence-slim/1.9.91)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants