Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenCensus spans should close on IOExceptions #797

Merged
merged 8 commits into from Aug 28, 2019
Merged

fix: OpenCensus spans should close on IOExceptions #797

merged 8 commits into from Aug 28, 2019

Conversation

chingor13
Copy link
Collaborator

Fixes #788

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
@chingor13 chingor13 marked this pull request as ready for review August 28, 2019 14:09
@chingor13 chingor13 requested a review from a team as a code owner August 28, 2019 14:09
@chingor13 chingor13 merged commit 41f6a2f into googleapis:master Aug 28, 2019
@chingor13 chingor13 deleted the opencensus-spans branch August 28, 2019 16:40
@chingor13 chingor13 mentioned this pull request Sep 11, 2019
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@renovate-bot @eaball35
chore(deps): update dependency com.coveo:fmt-maven-plugin to v2.13 (g…
af702ef 
…oogleapis#797)

Co-authored-by: Emily Ball <emilyball@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

com.google.api.client.http.HttpRequest.execute doesn't close Span
3 participants
@chingor13 @elharo @googlebot