Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid excessive newlines for short variable names with --aosp #970

Open
agrieve opened this issue Sep 14, 2023 · 0 comments
Open

Avoid excessive newlines for short variable names with --aosp #970

agrieve opened this issue Sep 14, 2023 · 0 comments

Comments

@agrieve
Copy link

agrieve commented Sep 14, 2023

I'm trying this out in chromium codebase, and besides the known-issue of excessive lambda whitespace (issue #19), I'm finding the most jarring thing is odd whitespace for variable assignments.

google-java-format does:

                desc =
                        getResources()
                                .getString(R.string.cablev2_error_ble_permission, packageLabel);

instead of:

                desc = getResources()
                                .getString(R.string.cablev2_error_ble_permission, packageLabel);

I'm guessing it might be because with two space indents, the wrapped line appears under the = sign (which looks less weird), but with four space indent, it looks really odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant