diff --git a/gson/src/main/java/com/google/gson/internal/bind/ObjectTypeAdapter.java b/gson/src/main/java/com/google/gson/internal/bind/ObjectTypeAdapter.java index ec42e04826..62dc85fc1d 100644 --- a/gson/src/main/java/com/google/gson/internal/bind/ObjectTypeAdapter.java +++ b/gson/src/main/java/com/google/gson/internal/bind/ObjectTypeAdapter.java @@ -27,6 +27,7 @@ import java.io.IOException; import java.util.ArrayList; +import java.util.LinkedList; import java.util.List; import java.util.Map; @@ -51,42 +52,97 @@ public final class ObjectTypeAdapter extends TypeAdapter { this.gson = gson; } - @Override public Object read(JsonReader in) throws IOException { - JsonToken token = in.peek(); - switch (token) { - case BEGIN_ARRAY: - List list = new ArrayList(); + /** + * Tries to begin reading a JSON array or JSON object, returning {@code null} if + * the next element is neither of those. + */ + private Object tryBeginNesting(JsonReader in, JsonToken peeked) throws IOException { + if (peeked == JsonToken.BEGIN_ARRAY) { in.beginArray(); - while (in.hasNext()) { - list.add(read(in)); - } - in.endArray(); - return list; - - case BEGIN_OBJECT: - Map map = new LinkedTreeMap(); + return new ArrayList(); + } else if (peeked == JsonToken.BEGIN_OBJECT) { in.beginObject(); - while (in.hasNext()) { - map.put(in.nextName(), read(in)); - } - in.endObject(); - return map; + return new LinkedTreeMap(); + } else { + return null; + } + } + /** Reads an {@code Object} which cannot have any nested elements */ + private Object readTerminal(JsonReader in, JsonToken peeked) throws IOException { + switch (peeked) { case STRING: return in.nextString(); - case NUMBER: return in.nextDouble(); - case BOOLEAN: return in.nextBoolean(); - case NULL: in.nextNull(); return null; - default: - throw new IllegalStateException(); + // When read(JsonReader) is called with JsonReader in invalid state + throw new IllegalStateException("Unexpected token: " + peeked); + } + } + + @Override public Object read(JsonReader in) throws IOException { + // Either List or Map + Object current; + JsonToken peeked = in.peek(); + + current = tryBeginNesting(in, peeked); + if (current == null) { + return readTerminal(in, peeked); + } + + LinkedList stack = new LinkedList(); + + while (true) { + while (in.hasNext()) { + String name = null; + // Name is only used for JSON object members + if (current instanceof Map) { + name = in.nextName(); + } + + peeked = in.peek(); + Object value = tryBeginNesting(in, peeked); + boolean isNesting = value != null; + + if (value == null) { + value = readTerminal(in, peeked); + } + + if (current instanceof List) { + @SuppressWarnings("unchecked") + List list = (List) current; + list.add(value); + } else { + @SuppressWarnings("unchecked") + Map map = (Map) current; + map.put(name, value); + } + + if (isNesting) { + stack.addLast(current); + current = value; + } + } + + // End current element + if (current instanceof List) { + in.endArray(); + } else { + in.endObject(); + } + + if (stack.isEmpty()) { + return current; + } else { + // Continue with enclosing element + current = stack.removeLast(); + } } } diff --git a/gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java b/gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java index 354ce5a1fb..bf040228c4 100644 --- a/gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java +++ b/gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java @@ -31,6 +31,7 @@ import java.util.Date; import java.util.GregorianCalendar; import java.util.HashMap; +import java.util.LinkedList; import java.util.List; import java.util.Locale; import java.util.Map; @@ -406,7 +407,7 @@ public void write(JsonWriter out, String value) throws IOException { out.value(value); } }; - + public static final TypeAdapter BIG_DECIMAL = new TypeAdapter() { @Override public BigDecimal read(JsonReader in) throws IOException { if (in.peek() == JsonToken.NULL) { @@ -424,7 +425,7 @@ public void write(JsonWriter out, String value) throws IOException { out.value(value); } }; - + public static final TypeAdapter BIG_INTEGER = new TypeAdapter() { @Override public BigInteger read(JsonReader in) throws IOException { if (in.peek() == JsonToken.NULL) { @@ -696,8 +697,25 @@ public void write(JsonWriter out, Locale value) throws IOException { public static final TypeAdapterFactory LOCALE_FACTORY = newFactory(Locale.class, LOCALE); public static final TypeAdapter JSON_ELEMENT = new TypeAdapter() { - @Override public JsonElement read(JsonReader in) throws IOException { - switch (in.peek()) { + /** + * Tries to begin reading a JSON array or JSON object, returning {@code null} if + * the next element is neither of those. + */ + private JsonElement tryBeginNesting(JsonReader in, JsonToken peeked) throws IOException { + if (peeked == JsonToken.BEGIN_ARRAY) { + in.beginArray(); + return new JsonArray(); + } else if (peeked == JsonToken.BEGIN_OBJECT) { + in.beginObject(); + return new JsonObject(); + } else { + return null; + } + } + + /** Reads a {@link JsonElement} which cannot have any nested elements */ + private JsonElement readTerminal(JsonReader in, JsonToken peeked) throws IOException { + switch (peeked) { case STRING: return new JsonPrimitive(in.nextString()); case NUMBER: @@ -708,28 +726,65 @@ public void write(JsonWriter out, Locale value) throws IOException { case NULL: in.nextNull(); return JsonNull.INSTANCE; - case BEGIN_ARRAY: - JsonArray array = new JsonArray(); - in.beginArray(); + default: + // When read(JsonReader) is called with JsonReader in invalid state + throw new IllegalStateException("Unexpected token: " + peeked); + } + } + + @Override public JsonElement read(JsonReader in) throws IOException { + // Either JsonArray or JsonObject + JsonElement current; + JsonToken peeked = in.peek(); + + current = tryBeginNesting(in, peeked); + if (current == null) { + return readTerminal(in, peeked); + } + + LinkedList stack = new LinkedList(); + + while (true) { while (in.hasNext()) { - array.add(read(in)); + String name = null; + // Name is only used for JSON object members + if (current instanceof JsonObject) { + name = in.nextName(); + } + + peeked = in.peek(); + JsonElement value = tryBeginNesting(in, peeked); + boolean isNesting = value != null; + + if (value == null) { + value = readTerminal(in, peeked); + } + + if (current instanceof JsonArray) { + ((JsonArray) current).add(value); + } else { + ((JsonObject) current).add(name, value); + } + + if (isNesting) { + stack.addLast(current); + current = value; + } } - in.endArray(); - return array; - case BEGIN_OBJECT: - JsonObject object = new JsonObject(); - in.beginObject(); - while (in.hasNext()) { - object.add(in.nextName(), read(in)); + + // End current element + if (current instanceof JsonArray) { + in.endArray(); + } else { + in.endObject(); + } + + if (stack.isEmpty()) { + return current; + } else { + // Continue with enclosing element + current = stack.removeLast(); } - in.endObject(); - return object; - case END_DOCUMENT: - case NAME: - case END_OBJECT: - case END_ARRAY: - default: - throw new IllegalArgumentException(); } } diff --git a/gson/src/test/java/com/google/gson/JsonParserParameterizedTest.java b/gson/src/test/java/com/google/gson/JsonParserParameterizedTest.java new file mode 100644 index 0000000000..7e0982b7af --- /dev/null +++ b/gson/src/test/java/com/google/gson/JsonParserParameterizedTest.java @@ -0,0 +1,42 @@ +package com.google.gson; + +import static org.junit.Assert.assertEquals; + +import java.io.IOException; +import java.util.Arrays; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameter; +import org.junit.runners.Parameterized.Parameters; + +@RunWith(Parameterized.class) +public class JsonParserParameterizedTest { + @Parameters + public static Iterable data() { + return Arrays.asList( + "[]", + "{}", + "null", + "1.0", + "true", + "\"string\"", + "[true,1.0,null,{},2.0,{\"a\":[false]},[3.0,\"test\"],4.0]", + "{\"\":1.0,\"a\":true,\"b\":null,\"c\":[],\"d\":{\"a1\":2.0,\"b2\":[true,{\"a3\":3.0}]},\"e\":[{\"f\":4.0},\"test\"]}" + ); + } + + private final TypeAdapter adapter = new Gson().getAdapter(JsonElement.class); + @Parameter + public String json; + + @Test + public void testParse() throws IOException { + JsonElement deserialized = JsonParser.parseString(json); + String actualSerialized = adapter.toJson(deserialized); + + // Serialized JsonElement should be the same as original JSON + assertEquals(json, actualSerialized); + } +} diff --git a/gson/src/test/java/com/google/gson/JsonParserTest.java b/gson/src/test/java/com/google/gson/JsonParserTest.java index cc18238be4..a05aa32296 100644 --- a/gson/src/test/java/com/google/gson/JsonParserTest.java +++ b/gson/src/test/java/com/google/gson/JsonParserTest.java @@ -18,8 +18,8 @@ import java.io.CharArrayReader; import java.io.CharArrayWriter; +import java.io.IOException; import java.io.StringReader; - import junit.framework.TestCase; import com.google.gson.common.TestTypes.BagOfPrimitives; @@ -90,6 +90,54 @@ public void testParseMixedArray() { assertEquals("stringValue", array.get(2).getAsString()); } + private static String repeat(String s, int times) { + StringBuilder stringBuilder = new StringBuilder(s.length() * times); + for (int i = 0; i < times; i++) { + stringBuilder.append(s); + } + return stringBuilder.toString(); + } + + /** Deeply nested JSON arrays should not cause {@link StackOverflowError} */ + public void testParseDeeplyNestedArrays() throws IOException { + int times = 10000; + // [[[ ... ]]] + String json = repeat("[", times) + repeat("]", times); + + int actualTimes = 0; + JsonArray current = JsonParser.parseString(json).getAsJsonArray(); + while (true) { + actualTimes++; + if (current.isEmpty()) { + break; + } + assertEquals(1, current.size()); + current = current.get(0).getAsJsonArray(); + } + assertEquals(times, actualTimes); + } + + /** Deeply nested JSON objects should not cause {@link StackOverflowError} */ + public void testParseDeeplyNestedObjects() throws IOException { + int times = 10000; + // {"a":{"a": ... {"a":null} ... }} + String json = repeat("{\"a\":", times) + "null" + repeat("}", times); + + int actualTimes = 0; + JsonObject current = JsonParser.parseString(json).getAsJsonObject(); + while (true) { + assertEquals(1, current.size()); + actualTimes++; + JsonElement next = current.get("a"); + if (next.isJsonNull()) { + break; + } else { + current = next.getAsJsonObject(); + } + } + assertEquals(times, actualTimes); + } + public void testParseReader() { StringReader reader = new StringReader("{a:10,b:'c'}"); JsonElement e = JsonParser.parseReader(reader); diff --git a/gson/src/test/java/com/google/gson/ObjectTypeAdapterParameterizedTest.java b/gson/src/test/java/com/google/gson/ObjectTypeAdapterParameterizedTest.java new file mode 100644 index 0000000000..f467f420ab --- /dev/null +++ b/gson/src/test/java/com/google/gson/ObjectTypeAdapterParameterizedTest.java @@ -0,0 +1,42 @@ +package com.google.gson; + +import static org.junit.Assert.assertEquals; + +import java.io.IOException; +import java.util.Arrays; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameter; +import org.junit.runners.Parameterized.Parameters; + +@RunWith(Parameterized.class) +public class ObjectTypeAdapterParameterizedTest { + @Parameters + public static Iterable data() { + return Arrays.asList( + "[]", + "{}", + "null", + "1.0", + "true", + "\"string\"", + "[true,1.0,null,{},2.0,{\"a\":[false]},[3.0,\"test\"],4.0]", + "{\"\":1.0,\"a\":true,\"b\":null,\"c\":[],\"d\":{\"a1\":2.0,\"b2\":[true,{\"a3\":3.0}]},\"e\":[{\"f\":4.0},\"test\"]}" + ); + } + + private final TypeAdapter adapter = new Gson().getAdapter(Object.class); + @Parameter + public String json; + + @Test + public void testReadWrite() throws IOException { + Object deserialized = adapter.fromJson(json); + String actualSerialized = adapter.toJson(deserialized); + + // Serialized Object should be the same as original JSON + assertEquals(json, actualSerialized); + } +} diff --git a/gson/src/test/java/com/google/gson/ObjectTypeAdapterTest.java b/gson/src/test/java/com/google/gson/ObjectTypeAdapterTest.java index 2891bffca0..eed21a6a2b 100644 --- a/gson/src/test/java/com/google/gson/ObjectTypeAdapterTest.java +++ b/gson/src/test/java/com/google/gson/ObjectTypeAdapterTest.java @@ -16,9 +16,11 @@ package com.google.gson; +import java.io.IOException; import java.util.Arrays; import java.util.Collections; import java.util.LinkedHashMap; +import java.util.List; import java.util.Map; import junit.framework.TestCase; @@ -38,7 +40,7 @@ public void testSerialize() throws Exception { Object object = new RuntimeType(); assertEquals("{'a':5,'b':[1,2,null]}", adapter.toJson(object).replace("\"", "'")); } - + public void testSerializeNullValue() throws Exception { Map map = new LinkedHashMap(); map.put("a", null); @@ -55,6 +57,51 @@ public void testSerializeObject() throws Exception { assertEquals("{}", adapter.toJson(new Object())); } + private static String repeat(String s, int times) { + StringBuilder stringBuilder = new StringBuilder(s.length() * times); + for (int i = 0; i < times; i++) { + stringBuilder.append(s); + } + return stringBuilder.toString(); + } + + /** Deeply nested JSON arrays should not cause {@link StackOverflowError} */ + @SuppressWarnings("unchecked") + public void testDeserializeDeeplyNestedArrays() throws IOException { + int times = 10000; + // [[[ ... ]]] + String json = repeat("[", times) + repeat("]", times); + + int actualTimes = 0; + List> current = (List>) adapter.fromJson(json); + while (true) { + actualTimes++; + if (current.isEmpty()) { + break; + } + assertEquals(1, current.size()); + current = (List>) current.get(0); + } + assertEquals(times, actualTimes); + } + + /** Deeply nested JSON objects should not cause {@link StackOverflowError} */ + @SuppressWarnings("unchecked") + public void testDeserializeDeeplyNestedObjects() throws IOException { + int times = 10000; + // {"a":{"a": ... {"a":null} ... }} + String json = repeat("{\"a\":", times) + "null" + repeat("}", times); + + int actualTimes = 0; + Map> current = (Map>) adapter.fromJson(json); + while (current != null) { + assertEquals(1, current.size()); + actualTimes++; + current = (Map>) current.get("a"); + } + assertEquals(times, actualTimes); + } + @SuppressWarnings("unused") private class RuntimeType { Object a = 5;