Add @DoNotMock to Traverser.

RELNOTES=Add @DoNotMock to Traverser ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=321469875
google · Jul 16, 2020 · 6410f18 · 6410f18
1 parent da93601
commit 6410f18
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/android/guava-tests/test/com/google/common/graph/TraverserTest.java b/android/guava-tests/test/com/google/common/graph/TraverserTest.java
@@ -383,8 +383,8 @@ public void forGraph_depthFirstPreOrderIterable_javadocExample_canBeIteratedMult
   @Test
   public void forGraph_depthFirstPreOrder_infinite() {
     Iterable<Integer> result =
-        Traverser.forGraph(fixedSuccessors(Iterables.cycle(1, 2, 3))).breadthFirst(0);
-    assertThat(Iterables.limit(result, 2)).containsExactly(0, 1).inOrder();
+        Traverser.forGraph(fixedSuccessors(Iterables.cycle(1, 2, 3))).depthFirstPreOrder(0);
+    assertThat(Iterables.limit(result, 3)).containsExactly(0, 1, 2).inOrder();
   }
 
   @Test

diff --git a/android/guava/src/com/google/common/graph/Traverser.java b/android/guava/src/com/google/common/graph/Traverser.java
@@ -22,6 +22,7 @@
 import com.google.common.annotations.Beta;
 import com.google.common.collect.AbstractIterator;
 import com.google.common.collect.ImmutableSet;
+import com.google.errorprone.annotations.DoNotMock;
 import java.util.ArrayDeque;
 import java.util.Deque;
 import java.util.HashSet;
@@ -59,6 +60,9 @@
  * @since 23.1
  */
 @Beta
+@DoNotMock(
+    "Call forGraph or forTree, passing a lambda or a Graph with the desired edges (built with"
+        + " GraphBuilder)")
 public abstract class Traverser<N> {
   private final SuccessorsFunction<N> successorFunction;
 

diff --git a/guava-tests/test/com/google/common/graph/TraverserTest.java b/guava-tests/test/com/google/common/graph/TraverserTest.java
@@ -383,8 +383,8 @@ public void forGraph_depthFirstPreOrderIterable_javadocExample_canBeIteratedMult
   @Test
   public void forGraph_depthFirstPreOrder_infinite() {
     Iterable<Integer> result =
-        Traverser.forGraph(fixedSuccessors(Iterables.cycle(1, 2, 3))).breadthFirst(0);
-    assertThat(Iterables.limit(result, 2)).containsExactly(0, 1).inOrder();
+        Traverser.forGraph(fixedSuccessors(Iterables.cycle(1, 2, 3))).depthFirstPreOrder(0);
+    assertThat(Iterables.limit(result, 3)).containsExactly(0, 1, 2).inOrder();
   }
 
   @Test

diff --git a/guava/src/com/google/common/graph/Traverser.java b/guava/src/com/google/common/graph/Traverser.java
@@ -22,6 +22,7 @@
 import com.google.common.annotations.Beta;
 import com.google.common.collect.AbstractIterator;
 import com.google.common.collect.ImmutableSet;
+import com.google.errorprone.annotations.DoNotMock;
 import java.util.ArrayDeque;
 import java.util.Deque;
 import java.util.HashSet;
@@ -59,6 +60,9 @@
  * @since 23.1
  */
 @Beta
+@DoNotMock(
+    "Call forGraph or forTree, passing a lambda or a Graph with the desired edges (built with"
+        + " GraphBuilder)")
 public abstract class Traverser<N> {
   private final SuccessorsFunction<N> successorFunction;