Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI for newer JDK versions #6830

Closed
cpovirk opened this issue Nov 10, 2023 · 1 comment
Closed

Set up CI for newer JDK versions #6830

cpovirk opened this issue Nov 10, 2023 · 1 comment
Labels
P3 package=general type=other Miscellaneous activities not covered by other type= labels

Comments

@cpovirk
Copy link
Member

cpovirk commented Nov 10, 2023

I learned while looking at #4005 (comment) that our build failed under JDK 21+ with a legitimate Animal Sniffer error as of 945ce37. [edit: But the failure resolved when I reverted that commit.] That seems like the kind of thing that we'd want to know.

I do have some fear about multiplying the increasing of JDK versions that we test against, though, given that CI is already slow. I wonder if we can convince ourselves that we could remove either 11 or 17 as part of adding 21 (or even 22).

This leads me to a thought about toolchains, which I'll leave in #6549.

@sgammon
Copy link
Contributor

sgammon commented Mar 20, 2024

@cpovirk I think this can be closed :) JDK 22 did come out yesterday, but the distance between 17 and 21 is much greater than the distance between 21 and 22.

@cpovirk cpovirk closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 package=general type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Development

No branches or pull requests

2 participants