Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After updating to KSP 1.7.0, Missing information occurs in some cases that are configured in Java. #1034

Closed
Pluu opened this issue Jul 3, 2022 · 1 comment · Fixed by #1049
Closed

After updating to KSP 1.7.0, Missing information occurs in some cases that are configured in Java. #1034

Pluu opened this issue Jul 3, 2022 · 1 comment · Fixed by #1049
Assignees
@neetopia
Labels
bug Something isn't working
Milestone
1.0.7

Comments

@Pluu
Copy link

Pluu commented Jul 3, 2022

After updating to KSP 1.7.0 version, it was confirmed that some cases were different from the existing ones.

  • "KSPropertyDeclaration" information was missing in some cases.

I don't know if it's a Kotlin or KSP problem.
first report it to the KSP side.

Type diff

Case Kotlin 1.6.21 + KSP 1.6.21-1.0.6 Kotlin 1.7.0 + KSP 1.7.0-1.0.6
String O O
Int O O
Inner enum class in another files O O
Inner enum class O X

Kotlin 1.6.21 + KSP 1.6.21-1.0.6

Kotlin

w: [ksp] /.../SampleKotlin.kt:7: >> property: a1 : kotlin.String
w: [ksp] /.../SampleKotlin.kt:10: >> property: b1 : kotlin.Int
w: [ksp] /.../SampleKotlin.kt:13: >> property: c1 : com.pluu.kspsample.Sample2.SampleEnum
w: [ksp] /.../SampleKotlin.kt:16: >> property: d1 : com.pluu.kspsample.SampleKotlin.Type

Java

w: [ksp] /.../SampleJava.java:7: >> property: a2 : kotlin.String
w: [ksp] /.../SampleJava.java:10: >> property: b2 : kotlin.Int
w: [ksp] /.../SampleJava.java:13: >> property: c2 : com.pluu.kspsample.Sample2.SampleEnum
w: [ksp] /.../SampleJava.java:16: >> property: d2 : com.pluu.kspsample.SampleJava.Type

Kotlin 1.7.0 + KSP 1.7.0-1.0.6

Kotlin

w: [ksp] /.../SampleKotlin.kt:7: >> property: a1 : kotlin.String
w: [ksp] /.../SampleKotlin.kt:10: >> property: b1 : kotlin.Int
w: [ksp] /.../SampleKotlin.kt:13: >> property: c1 : com.pluu.kspsample.Sample2.SampleEnum
w: [ksp] /.../SampleKotlin.kt:16: >> property: d1 : com.pluu.kspsample.SampleKotlin.Type

Java

w: [ksp] /.../SampleJava.java:7: >> property: a2 : kotlin.String
w: [ksp] /.../SampleJava.java:10: >> property: b2 : kotlin.Int
w: [ksp] /.../SampleJava.java:13: >> property: c2 : com.pluu.kspsample.Sample2.SampleEnum
w: [ksp] Unable to process:PluuProcessor:   d2
@elihart
Copy link

elihart commented Jul 6, 2022 •
edited

I am also seeing this problem with interfaces that are nested in java classes. KSP reports the type as error.NonExistentClass

@neetopia neetopia self-assigned this Jul 11, 2022
@neetopia neetopia added this to the 1.0.7 milestone Jul 11, 2022
@neetopia neetopia added the bug Something isn't working label Jul 11, 2022
neetopia added a commit to neetopia/ksp that referenced this issue Jul 29, 2022
@neetopia
Force resolve outermost class for Java nested classes.
939b6ce 
This is a temporary workaround for google#1034
neetopia added a commit to neetopia/ksp that referenced this issue Jul 29, 2022
@neetopia
Force resolve outermost class for Java nested classes.
8b72f7f 
This is a temporary workaround for google#1034
neetopia added a commit to neetopia/ksp that referenced this issue Jul 29, 2022
@neetopia
Force resolve outermost class for Java nested classes.
af07a1a 
This is a temporary workaround for google#1034
@neetopia neetopia mentioned this issue Jul 29, 2022
Merged
neetopia added a commit that referenced this issue Jul 29, 2022
@neetopia
Force resolve outermost class for Java nested classes.
5f5977e 
This is a temporary workaround for #1034
github-actions bot pushed a commit that referenced this issue Jul 29, 2022
@neetopia
Force resolve outermost class for Java nested classes.
2e00149 
This is a temporary workaround for #1034

(cherry picked from commit 5f5977e)
@WindSekirun WindSekirun mentioned this issue Oct 17, 2022
Closed
Jeffset added a commit to yandex/yatagan that referenced this issue Dec 13, 2022
@Jeffset
Ksp: Write test for nested java interface and disable for KSP.
9e8d507 
KSP is broken: google/ksp#1034
Fixed in 1.0.7.
ting-yuan added a commit to ting-yuan/ksp that referenced this issue Jul 1, 2023
@ting-yuan
Remove a workaround for nested classes
7823f2a 
The proper fix had landed in Kotlin 1.8.20.
See google#1034 for details.
ting-yuan added a commit to ting-yuan/ksp that referenced this issue Jul 1, 2023
@ting-yuan
Remove a workaround for nested classes
4f231b8 
The proper fix had landed in Kotlin 1.8.20.
See google#1034 for details.
ting-yuan added a commit that referenced this issue Jul 5, 2023
@ting-yuan
Remove a workaround for nested classes
6fc491e 
The proper fix had landed in Kotlin 1.8.20.
See #1034 for details.
github-actions bot pushed a commit that referenced this issue Jul 5, 2023
@ting-yuan
Remove a workaround for nested classes
3e1e9a2 
The proper fix had landed in Kotlin 1.8.20.
See #1034 for details.

(cherry picked from commit 6fc491e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.7
Development

Successfully merging a pull request may close this issue.

Force resolve outermost class for Java nested classes. neetopia/ksp
3 participants
@Pluu @elihart @neetopia