[KSP2] NoClassDefFoundError for LZ4Factory when trying KSP2

[ZacSweers]

Repro

Checkout this PR: slackhq/kotlin-cli-util#111

Run ./gradlew check -Pksp.useKSP2=true

This is using 2.0.0-Beta3-1.0.17

Trace

Caused by: java.lang.NoClassDefFoundError: net/jpountz/lz4/LZ4Factory
        at com.intellij.util.CompressionUtil.compressor(CompressionUtil.java:81)
        at com.intellij.util.CompressionUtil.writeCompressedWithoutOriginalBufferLength(CompressionUtil.java:60)
        at com.intellij.util.io.CompressedAppendableFile.compress(CompressedAppendableFile.java:349)
        at com.intellij.util.io.CompressedAppendableFile.saveNextChunkIfNeeded(CompressedAppendableFile.java:314)
        at com.intellij.util.io.CompressedAppendableFile.append(CompressedAppendableFile.java:272)
        at com.intellij.util.io.PersistentHashMapValueStorage$4.write(PersistentHashMapValueStorage.java:222)
        at com.intellij.util.io.DataOutputStream.write(DataOutputStream.java:35)
        at com.intellij.util.io.PersistentHashMapValueStorage.doAppendBytes(PersistentHashMapValueStorage.java:238)
        at com.intellij.util.io.PersistentHashMapValueStorage.appendBytes(PersistentHashMapValueStorage.java:205)
        at com.intellij.util.io.PersistentHashMapValueStorage.appendBytes(PersistentHashMapValueStorage.java:175)
        at com.intellij.util.io.PersistentMapImpl.doPut(PersistentMapImpl.java:380)
        at com.intellij.util.io.PersistentMapImpl.put(PersistentMapImpl.java:360)
        at com.intellij.util.io.PersistentHashMap.put(PersistentHashMap.java:102)
        at com.google.devtools.ksp.PersistentMap.set(PersistentMap.kt:26)
        at com.google.devtools.ksp.IncrementalContextBase.updateCaches$update(IncrementalContextBase.kt:371)
        at com.google.devtools.ksp.IncrementalContextBase.updateCaches(IncrementalContextBase.kt:390)
        at com.google.devtools.ksp.IncrementalContextBase.updateCachesAndOutputs(IncrementalContextBase.kt:473)
        at com.google.devtools.ksp.impl.KotlinSymbolProcessing.execute(KotlinSymbolProcessing.kt:567)
        at com.google.devtools.ksp.impl.KSPLoader$Companion.loadAndRunKSP(KSPLoader.kt:36)
        at com.google.devtools.ksp.impl.KSPLoader.loadAndRunKSP(KSPLoader.kt)

[eygraber]

@ZacSweers were you able to find a workaround for this?

[eygraber]

Also not sure if you're experiencing this, but I'm only getting this error for Apple targets (ios, watchos, tvos, macos, etc...) even though I'm running on a Linux host.

Update: removing the Apple targets makes the error go away.

[ZacSweers]

Not worked around it so far

[eygraber]

And now it happens for me even without the Apple targets ☹️

[ting-yuan]

Similar to #1665, where some dependencies of KSP2 are not packed properly.

[ting-yuan]

Fixed in #1749 which is available in the nightly build, and will be included in the future 1.0.18 release.

[aftabahmadTW]

@ting-yuan Not sure if this is related but on the latest 1.0.19 for Kotlin Beta04 and with KSP2=true, I get:

[ksp] java.lang.AssertionError: java.lang.ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor
Caused by: java.lang.AssertionError: java.lang.ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor
	at net.jpountz.lz4.LZ4Factory.instance(LZ4Factory.java:53)
	at net.jpountz.lz4.LZ4Factory.safeInstance(LZ4Factory.java:105)
	at net.jpountz.lz4.LZ4Factory.fastestJavaInstance(LZ4Factory.java:141)
	at com.intellij.util.CompressionUtil.compressor(CompressionUtil.java:81)
	at com.intellij.util.CompressionUtil.writeCompressedWithoutOriginalBufferLength(CompressionUtil.java:60)

[ZacSweers]

I am still seeing this as well, same error as above. Repro:

ZacSweers/CatchUp#1089

https://github.com/ZacSweers/CatchUp/actions/runs/8198029572/job/22420905486?pr=1089#step:12:458

[li-fcb1899]

@ting-yuan Not sure if this is related but on the latest 1.0.19 for Kotlin Beta04 and with KSP2=true, I get:

[ksp] java.lang.AssertionError: java.lang.ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor
Caused by: java.lang.AssertionError: java.lang.ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor
	at net.jpountz.lz4.LZ4Factory.instance(LZ4Factory.java:53)
	at net.jpountz.lz4.LZ4Factory.safeInstance(LZ4Factory.java:105)
	at net.jpountz.lz4.LZ4Factory.fastestJavaInstance(LZ4Factory.java:141)
	at com.intellij.util.CompressionUtil.compressor(CompressionUtil.java:81)
	at com.intellij.util.CompressionUtil.writeCompressedWithoutOriginalBufferLength(CompressionUtil.java:60)

also

[ting-yuan]

Should be fixed in #1816.