[KSP2] KSAnnotations with annotation properties with a default value always resolve to null

[ZacSweers]

Tested with 2.0.0-RC1-1.0.20

Given an annotation like so:

annotation class AnotherAnnotation(val input: String)

annotation class Example(
  val anotherAnnotation: AnotherAnnotation = AnotherAnnotation(""),
  val anotherAnnotationArray: Array<AnotherAnnotation> = [AnotherAnnotation("")],
)

@Example
class SomeAnnotatedClass

When reading the annotation instance off of SomeAnnotatedClass in a processor, the AnotherAnnotation default values are always null. I discovered this while preparing KotlinPoet for K2, with a repro available in this PR in the TestProcessorTest.removeDefaultValues test. If you breakpoint the isDefaultValue() check in KSAnnotation.toAnnotationSpec(), you can verify this behavior.

[eygraber]

Is this the same issue as #885 / https://youtrack.jetbrains.com/issue/KT-59526/Store-annotation-default-values-in-metadata-on-JVM?

[neetopia]

this should be fixed by #1871 .