Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import regression test files from other projects #337

Open
reyammer opened this issue Mar 28, 2024 · 2 comments
Open

Import regression test files from other projects #337

reyammer opened this issue Mar 28, 2024 · 2 comments
Assignees
Labels
testing This issue is about improving testing

Comments

@reyammer
Copy link
Collaborator

No description provided.

@reyammer reyammer added the testing This issue is about improving testing label Mar 28, 2024
@reyammer reyammer self-assigned this Mar 28, 2024
@github-actions github-actions bot added the needs triage This issue still needs triage by one of the maintainers label Mar 28, 2024
@SarthakNikhal
Copy link

@reyammer Can I help with this issue

@reyammer reyammer removed the needs triage This issue still needs triage by one of the maintainers label Apr 22, 2024
@reyammer
Copy link
Collaborator Author

Hey, sure thing! I would start with a couple of small sources so that I can provide feedback on how to organize the tests, sounds good?

Notes on the current plan:

  • store them under: tests_data/<name of the external project>/....
  • I would start with small textual examples; these extra tests are meant to be helpful to track how we are handling nasty cases, rather than checking that we get everyone right (we are training v2 as we speak, so things should get better soon)
  • I would start collecting the few examples from guesslang's README: https://github.com/yoeo/guesslang/tree/master. Let's store them under tests_data/guesslang_examples/*
  • Another good source to collect is corner cases discussed here: Links/Samples where language auto-detection doesn't work microsoft/vscode#131450 Let's store them under tests_data/vscode_examples/*

I would start with these above, let me know if you have any questions, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This issue is about improving testing
Projects
None yet
Development

No branches or pull requests

2 participants