Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate cache TTL #320

Open
hazcod opened this issue May 25, 2021 · 1 comment
Open

Certificate cache TTL #320

hazcod opened this issue May 25, 2021 · 1 comment

Comments

@hazcod
Copy link

hazcod commented May 25, 2021

Hi! Thank you for the project.

I've noticed that the generated MITM certificates are never purged from memory.
So in case of a long running instance of martian, the memory usage would only increase.

I think it would be nice to be able to use the Certificate Validity (SetValidity) as a TTL on the certificate map key.
@hazcod hazcod changed the title Certificate purging Certificate cache TTL May 25, 2021
@bramhaghosh
Copy link
Member

This seems reasonable - I'd be happy to review a PR that adds in this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bramhaghosh @hazcod