Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod cleanup #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

go.mod cleanup #344

wants to merge 1 commit into from

Conversation

nohajc
Copy link

@nohajc nohajc commented Jul 26, 2022

Out-of-sync go.mod with a reference to unused old version of protoc-gen-go-grpc causes a false positive finding in OWASP dependency-check.

Running go mod tidy fixes the issue. Also fixes #327.

@google-cla
Copy link

google-cla bot commented Jul 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CarstenLeue
Copy link

Hi @nohajc looks like the PR is not merged because of #344 (comment)

Would you be able to comply to these requirements?

@nohajc
Copy link
Author

nohajc commented Feb 2, 2024

Hello, this PR seems to be outdated as there are merge conflicts. The only thing I did was to run go mod tidy and submitted the result.

If this library is maintained again, I think it will be easier for you to close this PR and repeat the same steps on master (in case it's still needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of go mod tidy causes downstream issues
2 participants