Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: error on paths missing leading slash for JSON APIs #58

Open
bramhaghosh opened this issue Dec 21, 2015 · 1 comment
Open

url: error on paths missing leading slash for JSON APIs #58

bramhaghosh opened this issue Dec 21, 2015 · 1 comment
Milestone

Comments

@bramhaghosh
Copy link
Member

When using the url.Filter, when the path is malformed (does not have a leading slash), Martian silently ignores it.

@admtnnr
Copy link
Contributor

admtnnr commented Dec 23, 2015

If we have to handle this I would rather it return an error than silently change user input. What about the other parts of the URL? If we want this validation behavior it should probably extend to any/all modifiers that deal with URLs.

@admtnnr admtnnr changed the title Return a informative error or handle malformed paths on url.Filter url: error on paths missing leading slash for JSON APIs Dec 30, 2015
@bramhaghosh bramhaghosh added this to the v2.2 milestone Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants