This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Refactor GoogleCredentials.get_application_default #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dhermes
force-pushed
the
refactor-get-app-default
branch
3 times, most recently
from
9c45978
to
844774b
Compare
dhermes
referenced
this pull request
in dhermes/oauth2client
Dec 5, 2014
|
just merged the other one -- can you rebase and push? (just want to look at the diff one more time) |
dhermes
force-pushed
the
refactor-get-app-default
branch
from
844774b
to
3953ca5
Compare
|
@craigcitro Rebased and pushed. |
| except (ApplicationDefaultCredentialsError, ValueError) as error: | ||
| _raise_exception_for_reading_json(credentials_filename, extra_help, error) | ||
|
|
||
| def _get_implicit_credentials(): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
craigcitro
added a commit
that referenced
this pull request
Dec 6, 2014
Refactor GoogleCredentials.get_application_default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have a diffbase of #83 but we can't specify those on GitHub.
As in #83 (after #82), I prefer to rebase this after #83 is merged.