This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fixing code that causes test_oauth2client to fail. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: - Removing executable bit from "test_oauth2client". - Temporarily disabling slow (network bound) tests. - Making client.SETTINGS a class so it can be mutable. - Making GoogleCredentials._get_implicit_credentials a classmethod so it can access `cls`. - Changing use of `urlparse.parse_qs` to `urllib.parse.parse_qs` (did not get converted during Py3K switch). Partially addresses googleapis#85. Not closing out until slow tests are re-enabled and other test failures of `py33openssl14` and `py34openssl14` pass.
|
@craigcitro This will fail when Travis runs because of the failures in WDYT? |
craigcitro
added a commit
that referenced
this pull request
Dec 6, 2014
Fixing code that causes test_oauth2client to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
so it can access
cls.urlparse.parse_qstourllib.parse.parse_qs(didnot get converted during Py3K switch).
Partially addresses #85. Not closing out until slow tests are
re-enabled and other test failures of
py33openssl14andpy34openssl14pass.