Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely mark deleted Git entries as INVALID/withdrawn (and correctly handle undeletion) #2113

Open
andrewpollock opened this issue Apr 15, 2024 · 0 comments

Comments

@andrewpollock
Copy link
Contributor

There are expected situations where records in Git will be deleted, e.g. bitnami/vulndb#336 (comment)

#829 completely removed the behaviour of marking deleted Git entries as invalid, as a reaction to an upstream defect that caused all records for that source to temporarily disappear.

a) Revert #829, and add guardrails to refuse to process a source with more than (say) 10% of the records disappearing. This would have prevented what happened that caused #829 to be created. Refer to the guardrails as added as part of #2030 for inspiration

b) Ensure the importer can correctly transition an existing deleted and withdrawn Bug back to a non-withdrawn state if it gets undeleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant