Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragments in URLs to project files cause 404s #349

Open
justinfagnani opened this issue Nov 24, 2022 · 0 comments · May be fixed by #350
Open

Fragments in URLs to project files cause 404s #349

justinfagnani opened this issue Nov 24, 2022 · 0 comments · May be fixed by #350

Comments

@justinfagnani
Copy link
Contributor

This is a common need with the SVG <use> element which needs a URL and a fragment to identify an element by id.

Here's a repro with a <link> tag: https://lit.dev/playground/#gist=f5b3171f6cb1d37459832b9cae6193f3

Looking at the Network tab in dev tools, it doesn't look like the request URL includes the fragment, so I'm not sure if/how the service worker gets access to it, but it may need to strip of fragments before looking a file up in the project.

@justinfagnani justinfagnani linked a pull request Nov 24, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant