New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open preview in new tab button #354

Open

aomarks opened this issue Jan 4, 2023 · 0 comments · May be fixed by #381

Assignees

Member

aomarks commented Jan 4, 2023

It would be nice to have a button that opens the preview in a new tab/window.

Issues:

On Safari (mobile and desktop), opening the preview in a new tab doesn't work. It always returns a Not Found error, and seems to be bypassing the service worker. Chrome and Firefox work fine, though interestingly I noticed if you hard (shift) reload, you see the same effect (but just for that load -- reloading again fixes it).
The service worker URL won't be shareable. This could be confusing.

aomarks self-assigned this

vdegenne linked a pull request

that will close this issue

Add open preview in new tab button #381

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment