Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run tests with Node 15 #146

Merged
merged 1 commit into from Dec 4, 2020
Merged

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented Nov 20, 2020

This change will also result in Node 15 prebuilt binaries being released.

Two changes were made to testing as part of allowing tests with Node 15 to pass:

  • npm run clean is called when the test script exits. This ensures there are no stale binaries or javascript generated from typescript when the next test starts.
  • nvm is installed in /bin rather than /root. This is probably where is always should have been installed and eliminated permission issues during npm install. (I think the permission issues observed were related to npm install using a non-root user to run installation scripts combined with "/root" being the working directory).

@nolanmar511 nolanmar511 removed the request for review from macieksmuga November 20, 2020 18:25
@nolanmar511
Copy link
Contributor Author

Node 15 system test fails with:

+ timeout 60 npm install --quiet --nodedir=/root/.nvm/versions/node/v15.2.1
/usr/bin/env: 'node': Permission denied
npm ERR! code 126
npm ERR! path /src
npm ERR! command failed
npm ERR! command sh -c node-pre-gyp install --fallback-to-build

This is the same failure we see with V8 canary test.

@nolanmar511 nolanmar511 changed the title chore: Run tests with Node 15 DO NOT REVIEW chore: Run tests with Node 15 Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #146 (4187200) into master (01e0ac1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   42.21%   42.21%           
=======================================
  Files          14       14           
  Lines        2061     2061           
  Branches       42       42           
=======================================
  Hits          870      870           
  Misses       1173     1173           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e0ac1...4187200. Read the comment docs.

@nolanmar511 nolanmar511 changed the title DO NOT REVIEW chore: Run tests with Node 15 chore: Run tests with Node 15 Dec 2, 2020
@nolanmar511 nolanmar511 changed the title chore: Run tests with Node 15 DO NOT REVIEW: chore: Run tests with Node 15 Dec 2, 2020
@nolanmar511 nolanmar511 changed the title DO NOT REVIEW: chore: Run tests with Node 15 chore: Run tests with Node 15 Dec 2, 2020
@nolanmar511 nolanmar511 merged commit 42f720b into google:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants