Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrivacyInfo.xcprivacy is not included in the framework output built by Carthage #230

Open
teerapap opened this issue Mar 21, 2024 · 1 comment · May be fixed by #231
Open

PrivacyInfo.xcprivacy is not included in the framework output built by Carthage #230

teerapap opened this issue Mar 21, 2024 · 1 comment · May be fixed by #231

Comments

@teerapap
Copy link

In version 2.4.0, PrivacyInfo.xcprivacy manifest file is added but when I built the xcframework with Carthage, the file is not included in the build output.

It is because the privacy file is not inside the project file (Promises.xcodeproj) and Carthage builds from this project file.

I'm working on a PR to fix this.
@teerapap teerapap linked a pull request Mar 21, 2024 that will close this issue
Open
@ykjchen
Copy link
Collaborator

ykjchen commented Mar 25, 2024 •
edited

Thanks for the PR @teerapap.

Are there any Carthage users following this that could help validate #231?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PrivacyInfo.xcprivacy to the default project file for Carthage build teerapap/promises
2 participants
@teerapap @ykjchen