New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation issues #512
Comments
@jwijffels Can this problem be reproduced now? I tested v0.1.84 and v0.1.96 on mingw, both of them can be compiled successfully. Here is my environment: I compile sentencepiece with: D:\sentencepiece\sentencepiece\build>cmake -G "CodeBlocks - MinGW Makefiles" .. D:\sentencepiece\sentencepiece\build>make -j4 [ 2%] Building CXX object src/CMakeFiles/sentencepiece.dir//third_party/protobuf-lite/arena.cc.obj DECLARE_STREAM_OPERATORD:\sentencepiece\sentencepiece\third_party\protobuf-lite\common.cc:232:51:(long long , "%" GOOGLE_LL_FORMAT "d") DECLARE_STREAM_OPERATOR(long long , "%" GOOGLE_LL_FORMAT "d") 7:1: ERATOR (unsigned long long, "%" GOOGLE_LL_FORMAT "u")
note: D:\sentencepiece\sentencepiece\third_party\protobuf-lite\common.cc:247:1:in expansion of macro ' DECLARE_STREAM_OPERATORnote: ' ^~~~~~~~~~~~~~~~~~~~~~~DECLARE_STREAM_OPERATOR [ 13%] Building CXX object src/CMakeFiles/sentencepiece-static.dir//third_party/protobuf-lite/generated_message_table_driven_lite.cc.obj |
So i compiled successfully with gcc 7.3, you gcc version was 8.3.0? I think the problem of absl maybe related to the gcc version of mingw. |
The mingw with R ships indeed with gcc-8-3.0 (https://cran.r-project.org/bin/windows/Rtools/rtools40.html) I'll see that in sentencepiece release v0.1.95 you switched to third_party absl and that you updated the third_party protobuf which contained fixes for the UBSAN issues I reported at #595 and protocolbuffers/protobuf#2073 If I incorporate the current C++ code (commit 8420f21) I get the same make errors FYI: compilation makevars is at https://github.com/bnosac/sentencepiece/blob/master/src/Makevars
|
Ok, took me a while today but I found a solution. I'll do some more testing on sentencepiece 0.1.96 before I'll update the R package on CRAN inculding version 0.1.96 Thanks again. |
If uploaded the R package wrapping sentencepiece 0.1.96 to CRAN yesterday (https://cran.r-project.org/package=sentencepiece) Closing this as this error seems to be solved |
Hello again. I'm trying to upgrade the R package https://CRAN.R-project.org/package=sentencepiece which runs sentencepiece 0.1.84 to the current version so that it has BPE regularisation.
While doing that in Windows using the mingw compiler, I encountered the following compilation issues - looks mainly related to the use of absl strings.
Are you aware of these issues? Any plans on providing fixes?
This is the overview of the issues
This is the full compilation trace
The text was updated successfully, but these errors were encountered: