Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPT Mobile Viewport issue on horizontal scroll #8663

Closed
1 task
kelvinballoo opened this issue May 6, 2024 · 2 comments
Closed
1 task

NPT Mobile Viewport issue on horizontal scroll #8663

kelvinballoo opened this issue May 6, 2024 · 2 comments
Assignees
Labels
Next Up Issues to prioritize for definition P2 Low priority Squad 2 (Team M) Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@kelvinballoo
Copy link
Collaborator

kelvinballoo commented May 6, 2024

Bug Description

Testing on this section of the Testing instruction doc: https://docs.google.com/document/d/1PThnH5ZgpYksgOAW2xHI6ONeIaHk74mj9qm65dlE_1w/edit#heading=h.ufyp724raw20

Figma: https://www.figma.com/file/ntKPstnmguKI70A6xUJQVi/Application-Passwords?type=design&node-id=1-3267&mode=design&t=imRPtKsRHOwS6qSl-0

Steps to reproduce

  • Issue happens on mobile. I tested on iPhone 15Pro Max Safari.
  • To view the Authorize Application screen with the customized styling applied, use the following URL with the hostname of your WP site.
    wp-admin/authorize-application.php?app_name=GoogleServiceIntegration&app_id=123e4567-e89b-12d3-a456-426614174000&success_url=https%3A%2F%2Fpublishers.google.com%2Fsettings%2Fauthorization%2Fwordpress&sitekit=true
  • I don't know it's because the URL is too long but the viewport is scrollable horizontally. I would assume we would wrap the URLs.
  • And this is how it looked like after scrolling horizontally

Screenshots

IMG_5867

Additional Context

  • WP 5.6.13
  • PHP Version: 8.0
  • OS: 17.4.1
  • Browser: Safari
  • Plugin Version: 1.126.0
  • Device: iPhone 15Pro max

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Authorize Application screen should not allow horizontal scrolling on mobile devices.
  • Long URLs in any part of the screen, particularly in the "You will be sent to" description in the approve and reject sections, should be wrapped to prevent overflow.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@kelvinballoo kelvinballoo added the Type: Enhancement Improvement of an existing feature label May 6, 2024
@ivonac4 ivonac4 added Squad 2 (Team M) Issues for Squad 2 Next Up Issues to prioritize for definition labels May 6, 2024
@hussain-t hussain-t self-assigned this May 7, 2024
@hussain-t hussain-t added the P2 Low priority label May 7, 2024
@hussain-t
Copy link
Collaborator

Hi @kelvinballoo, I tested it on the iPhone 15 Pro Max device using Safari and Chrome. However, I couldn't reproduce the issue. The gray boxes are already wrapped. Please refer to the following screenshots.

Safari:

IMG_5931

IMG_5929

Chrome:

IMG_5932

IMG_5930

@hussain-t hussain-t assigned kelvinballoo and unassigned hussain-t May 13, 2024
@kelvinballoo
Copy link
Collaborator Author

The issue is actually happening on WP 5.6.13, not the latest versions.
Since it's an old version, it does not make sense to fix it.
According to WordPress stats only 0.9% of WordPress users are on 5.6.

As such, we are closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Up Issues to prioritize for definition P2 Low priority Squad 2 (Team M) Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants