-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Paragraph Styles Scope in the Authorize Application Screen #8673
Comments
IB ✅, thanks @hussain-t! |
QA Update
|
Hi @kelvinballoo, regarding your observations:
That's expected.
We only want to apply the nested paragraph styles to the |
QA update ✅Thanks @hussain-t Most of the Paragraph elements are within the The other footer paragraph are under |
Feature Description
The current implementation of paragraph styles on the Authorize Application screen applies too broadly, affecting all paragraphs, including those outside the intended
.auth-app-card
area. This issue aims to refine the scope of these styles to ensure they only affect the relevant sections of the screen, improving overall style specificity and reducing potential style conflicts.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
.authorize-application-php
should be restricted to only affect elements within the.auth-app-card
section.Implementation Brief
In
assets/sass/authorize-application/_googlesitekit-authorize-application.scss
:.authorize-application-php
to ensure they only affect elements within the.auth-app-card
section. See:site-kit-wp/assets/sass/authorize-application/_googlesitekit-authorize-application.scss
Lines 45 to 50 in b0c0c60
.googlesitekit-authorize-application__footer p
element:line-height: $lh-authorize-application-label-lg
margin: 19px 0 20px
Test Coverage
QA Brief
example.com
with your actual site domain:.auth-app-card
section.Changelog entry
The text was updated successfully, but these errors were encountered: