Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads.txt notification appears when a valid ads.txt file is already placed and recognised in AdSense #8678

Open
1 task
jamesozzie opened this issue May 8, 2024 · 0 comments
Labels
Module: AdSense Google AdSense module related issues Type: Bug Something isn't working Type: Support Support request

Comments

@jamesozzie
Copy link
Collaborator

jamesozzie commented May 8, 2024

Bug Description

When logging into a site with an existing ads.txt file, as recognized in AdSense (with an authorized status), Site Kit is displaying a "Earnings at risk" notification. This is despite an ads.txt file recognized in AdSense as per the screenshot below. (see this recording for full experience)

This may be an issue on the AdSense side, whereby some sites may have ads.txt issues, but not the site currently connected in Site Kit. I don't see any ads.txt specific API references, but I do see some alert related references:
https://developers.google.com/adsense/management/reference/rest/v2/accounts.alerts#list

image

image

Based on the below, this is likely an AdSense issue, however, possibly only application for users with sites that are approved but with different ads.txt status'

image

Steps to reproduce

  1. Go to the test site we use for Site Kit
  2. Notice the banner that appears regarding a missing ads.txt file
  3. When dismissing the banner, it will reappear after some time (or after logging out and in once more) - a separate issue which I'll open a different GitHub issue for.

Additional Context

  • SK version 1.126.0
  • This has occurred for some time
  • This was not raised by any user, it's more something evident from testing

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@jamesozzie jamesozzie added Type: Bug Something isn't working Type: Support Support request Module: AdSense Google AdSense module related issues labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: AdSense Google AdSense module related issues Type: Bug Something isn't working Type: Support Support request
Projects
None yet
Development

No branches or pull requests

1 participant