-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show one of the Consent Mode and Audience Segmentation Setup CTA Banners at a time. #8709
Comments
@ankitrox could you please add the estimate to this ticket? That should be included when submitting to IBR, so the reviewer can review the estimate as well. Thank you! |
Added the estimate in the ticket. |
I'm intentionally not sending this back to IB yet, as I'd like to discuss this feedback with @techanvil internally as this is one of my first IB reviews. Thank you for the excellent IB, @ankitrox ! The approach looks good. I have some minimal feedback:
I'd recommend that the component stays in
It might be worth mentioning that the extracted
I'd recommend against letting the extracted
I understand this is not a part of the ACs, but I think it might be worth also including
I understand that this is how the AC specs it out, however, looking at the bigger picture, we currently have (e.g. Keeping the above in mind, I'd recommend introducing a new The Let me know what you think. I'm absolutely open to any feedback/questions on the above. Of course, if the above feedback is applied, the estimate would need to notch up by 1 or 2 levels. Thank you! |
Feature Description
The initial integration of the Audience Segmentation Setup CTA Banner doesn't account for the fact the Consent Mode Setup CTA Banner may be shown at the same time.
We should ensure that only one of these banners is shown at a time. If they are both eligible to be displayed, the Consent Mode banner should take precedence.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Note that as per this comment, we should refactor the relevant components to avoid duplication of the inlined widget context and area structures.
SetupCTAWidget
insideassets/js/components/setup/
AudienceSegmentationSetupCTAWidget
andConsentModeSetupCTAWidget
is same, extract theSetupCTAWidget
component which will render the common markup.SetupCTAWidget
should accept the prop liketitle
,description
,handleCTAClick
,handleDismiss
,SVGItemComponent
andsetupSlug
.title
would be the title for the setup CTA widget.description
would be the description for the widget.handleCTAClick
callback when the CTA is clicked.handleDismiss
callback when the banner is dismissed.SVGItemComponent
component to render the SVG element. It can be wrapped up insideCell
component as bothConsentModeSetupCTAWidget
andAudienceSegmentationSetupCTAWidget
renders it withinCell
.setupSlug
can beaudience-segmentation
orconsent-mode
. This is useful to keep the css classes intact. We can use this prop where classes likegooglesitekit-audience-segmentation-setup-cta-widget
orgooglesitekit-consent-mode-setup-cta-widget
are being used, so that we can insert likegooglesitekit-${setupSlug}-setup-cta-widget
.isSaving
andsaveError
.AudienceSegmentationSetupCTAWidget
andConsentModeSetupCTAWidget
components can reuse the extracted component and pass the relevant props to it.displayConsentModeSetupWidget
in consent-mode data store. Condition to display the widget can be found inConsentModeSetupCTAWidget
component here.DashboardMainApp
, check if the consent mode setup widget can be display using the selector. If it can be displayed, do not renderAudienceSegmentationSetupCTAWidget
, else it should be rendered.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: