Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: allow specifying application as part of the wrap operation #249

Open
jakebiesinger-storyhealth opened this issue Jun 21, 2023 · 0 comments · May be fixed by #250
Open

nodejs: allow specifying application as part of the wrap operation #249

jakebiesinger-storyhealth opened this issue Jun 21, 2023 · 0 comments · May be fixed by #250

Comments

@jakebiesinger-storyhealth
Copy link

Currently all of the NodeJS sqlcommenter packages restrict the allowed comment entries to the DB driver, trace info, and the http route being served. I also want to specify the entry application so that I can tell where the query is coming from (especially in contexts that aren't serving http traffic!)

Are the allowed keys are being restricted on purpose? If so, would you accept a PR that allowed a static value for application to be specified at initialization time?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow additional comments to be added at initialization time jakebiesinger-storyhealth/sqlcommenter
1 participant
@jakebiesinger-storyhealth