Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UpdateSitelinkCampaignExtensionSetting #410

Closed
PierrickVoulet opened this issue Aug 27, 2020 · 2 comments
Closed

Fix UpdateSitelinkCampaignExtensionSetting #410

PierrickVoulet opened this issue Aug 27, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@PierrickVoulet
Copy link
Collaborator

Which version of the client library are you using?
V4.0.0

Which version of PHP are you using?
7.4

Which operating system (Linux, Windows, ...) and version?
Linux

Actions taken
Run the code example UpdateSitelinkCampaignExtensionSetting

Expected result
Successful run of the code example

Actual result
An API request fails:

"errors": [{
  "errorCode": {
    "extensionSettingError": "EXTENSION_SETTING_UPDATE_IS_A_NOOP"
  },
  "message": "The UPDATE operation does not specify any fields other than the resource name in the update mask.",
  "trigger":{
    "stringValue": ""
  },
  "location": {
    "fieldPathElements": [{
      "fieldName": "operations",
      "index": "0"
    }]
  }
}]  

Anything else we should know about your project / environment
It works fine when using the PHP implementation of protobuf but fails when using the C implementation
The difference of behavior is reported on protocolbuffers/protobuf#7650

@PierrickVoulet PierrickVoulet added the bug Something isn't working label Aug 27, 2020
@PierrickVoulet
Copy link
Collaborator Author

I just tested with protocolbuffers/protobuf#7650 and protocolbuffers/protobuf#7900 and it seems to be fixed. Let's wait for the next protobuf release before closing this though.

@PierrickVoulet PierrickVoulet self-assigned this Sep 23, 2020
@PierrickVoulet
Copy link
Collaborator Author

I am closing the issue because this is fixed with the newer release of protobuf (tested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant