Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not accept failure for PHP 8.0 Travis tests #479

Closed
PierrickVoulet opened this issue Dec 2, 2020 · 3 comments
Closed

Do not accept failure for PHP 8.0 Travis tests #479

PierrickVoulet opened this issue Dec 2, 2020 · 3 comments
Assignees
@PierrickVoulet
Labels
good first issue Good for newcomers maintenance This issue is related to long term maintenance

Comments

@PierrickVoulet
Copy link
Collaborator

Describe the problem you are trying to solve

The library unit tests for PHP 8.0 should not be allow to fail. It is currently the case some dependencies are still working to add the support to PHP 8.0:

  • Protobuf: issue 8078
  • gRPC: will be supported in next minor release (1.34.0)
  • Travis: will support PHP 8.0 environment soon

Describe the solution you would like

Update Travis configuration when possible.
@PierrickVoulet PierrickVoulet added enhancement New feature or request good first issue Good for newcomers maintenance This issue is related to long term maintenance usability This issue is related to a usability issue with the client library labels Dec 2, 2020
@PierrickVoulet PierrickVoulet self-assigned this Dec 2, 2020
@PierrickVoulet
Copy link
Collaborator Author

Update: gRPC released version 1.34.0 with PHP 8.0 support.

@PierrickVoulet PierrickVoulet removed enhancement New feature or request usability This issue is related to a usability issue with the client library labels Dec 11, 2020
@PierrickVoulet PierrickVoulet pinned this issue Feb 3, 2021
@PierrickVoulet PierrickVoulet mentioned this issue Feb 26, 2021
Closed
@PierrickVoulet
Copy link
Collaborator Author

Waiting for gRPC to release grpc/grpc-php 1.36.

@PierrickVoulet
Copy link
Collaborator Author

PierrickVoulet commented Mar 2, 2021 •
edited

Fixed by #530 .

@PierrickVoulet PierrickVoulet unpinned this issue Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickVoulet PierrickVoulet

Labels
good first issue Good for newcomers maintenance This issue is related to long term maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PierrickVoulet