Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf deprecation notice #744

Closed
ujwaldhakal opened this issue Feb 15, 2022 · 2 comments
Closed

Protobuf deprecation notice #744

ujwaldhakal opened this issue Feb 15, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@ujwaldhakal
Copy link
Contributor

ujwaldhakal commented Feb 15, 2022

[DO NOT INCLUDE ANY PERSONAL OR SENSITIVE DATA - MAKE SURE TO REDACT CONTENT WHEN NECESSARY]

Your question:

Currently I am using "googleads/google-ads-php": "^v13.0.0" with php8.1 and I am starting to get deprecation notices like

Deprecated: Return type of Google\Protobuf\Internal\RepeatedField::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/google/protobuf/src/Google/Protobuf/Internal/RepeatedField.php on line 233

When I visit this link protocolbuffers/protobuf#9293 it says the patch has been fixed.

@ujwaldhakal ujwaldhakal added question Further information is requested triage Need triage labels Feb 15, 2022
@PierrickVoulet
Copy link
Collaborator

Hi @ujwaldhakal,

This issue was fixed by Protobuf's team but it is not released yet. We currently support the versions ^3.19.4 of this dependency so you will have the possibility to update yours if their next version is a minor version. If their next version is a major version though, you are right, we will have to make plans to edit our rules.

@PierrickVoulet PierrickVoulet removed the triage Need triage label Feb 15, 2022
@PierrickVoulet PierrickVoulet self-assigned this Feb 15, 2022
@ujwaldhakal
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants