Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type definitions from error_details.proto #77

Open
nolanmar511 opened this issue Nov 22, 2017 · 2 comments
Open

Use type definitions from error_details.proto #77

nolanmar511 opened this issue Nov 22, 2017 · 2 comments
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@nolanmar511
Copy link
Contributor

ServerBackoffResponse (in pr #75) corresponds to a server response with RetryInfo in error_details.proto (here https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto). We should use (or at least investigate using) error_details.proto.
@ofrobots ofrobots self-assigned this Nov 30, 2017
ofrobots added a commit to ofrobots/cloud-profiler-nodejs that referenced this issue Nov 30, 2017
@ofrobots
build: add error_details definitions
71cc406 
Add js & type definitions generated from error_details.proto.

Fixes: googleapis#77
@ofrobots ofrobots mentioned this issue Nov 30, 2017
Closed
@aalexand
Copy link
Contributor

Whose next step here: @nolanmar511 or @ofrobots ? The issue is assigned to @ofrobots, is that right?

@nolanmar511 nolanmar511 assigned nolanmar511 and unassigned ofrobots Dec 15, 2017
@nolanmar511
Copy link
Contributor Author

It should be assigned to me.
I need to check if it is reasonable to switch to using the error_details definition.

@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 13, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ofrobots @JustinBeckwith @aalexand @nolanmar511