Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Error Message for Missing User Pin in Config File #90

Open
lcforges opened this issue Aug 21, 2023 · 0 comments
Open

Update Error Message for Missing User Pin in Config File #90

lcforges opened this issue Aug 21, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lcforges
Copy link
Contributor

lcforges commented Aug 21, 2023 •
edited

Currently, calling Cred with a json config file without a user pin throws the following error: "failed to retrieve certificate chain: unexpected EOF." The error message should be made more descriptive to show that certain fields are missing from the config.

Source: https://github.com/googleapis/enterprise-certificate-proxy/blob/main/client/client.go#L159C2-L161C3
@lcforges lcforges added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcforges