Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: emit generated code compatible with go 1.19 formatter #1103

Open
shollyman opened this issue Aug 9, 2022 · 1 comment
Open

FR: emit generated code compatible with go 1.19 formatter #1103

shollyman opened this issue Aug 9, 2022 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link

Go 1.19 changed aspects of the go formatter, particularly with respect to docstrings.

It would be preferable if the generator emitted generated code compatible with those guidelines, now that we're using go 1.19 as the latest version (which governs which version validates go formatting).
@shollyman shollyman added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 9, 2022
@shollyman
Copy link
Author

From https://tip.golang.org/doc/go1.19

Doc Comments
Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.

Additional information in https://tip.golang.org/doc/comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shollyman