Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "error processing line 1 of google-showcase-nspkg.pth" #1361

Closed
vchudnov-g opened this issue Jul 20, 2022 · 1 comment
Closed

fix "error processing line 1 of google-showcase-nspkg.pth" #1361

vchudnov-g opened this issue Jul 20, 2022 · 1 comment
Assignees
@vchudnov-g
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. test coverage type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Contributor

Running nox showcase test suites leads to errors of the form
Error processing line 1 of /usr/local/google/home/…/gapic-generator-python/.nox/showcase_alternative_templates/lib/python3.9/site-packages/google-showcase-nspkg.pth

A workaround is to go to the offending file and insert a newline after the import statement. However, I've seen the problem recur on subsequent test runs.

We should figure out where that file is coming from and fix it.

It may be originating from setuptools, since it seems to appears upon setup/installation, but I am not at all sure about that.

This affects test coverage, code hygiene, developer productivity, developer efficiency/satsifaction.
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. test coverage labels Jul 20, 2022
@vchudnov-g vchudnov-g self-assigned this Jul 20, 2022
@parthea
Copy link
Contributor

parthea commented Jan 20, 2024

I believe this should be resolved now that we've removed namespace_packages from setup.py. See related discussion in googleapis/gapic-generator#3334 (comment). I'm going to close this issue. We can open it again if the issue reappears.

@parthea parthea closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchudnov-g vchudnov-g

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. test coverage type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g