Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated option is ignored for messages and enums #1733

Open
parthea opened this issue Aug 11, 2023 · 0 comments · May be fixed by #1738
Open

Deprecated option is ignored for messages and enums #1733

parthea opened this issue Aug 11, 2023 · 0 comments · May be fixed by #1738
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Aug 11, 2023

In googleapis/googleapis@b7003aa, the deprecated option was added to the DB_CLOUD_SQL_POSTGRES field of DatabaseType in google/cloud/contentwarehouse/v1/common.proto, however the generated client in https://github.com/googleapis/google-cloud-python/pull/11565/files did not contain the deprecation message. We should add tests to make sure that the GAPIC generator can read the deprecated option.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 11, 2023
@parthea parthea changed the title Deprecated option is ignored Deprecated option is ignored for messages and enums Aug 11, 2023
This was referenced Aug 11, 2023
Closed
Draft
@parthea parthea self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@parthea