Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure async clients work over REST transport #1962

Open
vchudnov-g opened this issue Feb 28, 2024 · 1 comment
Open

Ensure async clients work over REST transport #1962

vchudnov-g opened this issue Feb 28, 2024 · 1 comment
Assignees
@parthea
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Feb 28, 2024 •
edited

Async clients do not seem to work over REST transport. This may well be technical debt (deferred work) from the initial REGAPIC implementation. We need to get it working.

Related issues:
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 28, 2024
@parthea
Copy link
Contributor

parthea commented Mar 11, 2024 •
edited

Switching to P1 feature request as this is a new feature rather than a regression.

This is blocked by googleapis/google-auth-library-python#613

The _aiohttp_requests module here to be made public.
https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/transport/_aiohttp_requests.py

@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g