Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Google mode? #1970

Open
techdragon opened this issue Mar 5, 2024 · 1 comment
Open

Non-Google mode? #1970

techdragon opened this issue Mar 5, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@techdragon
Copy link

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • A non-google mode where this compiler plugin just generates code like the current protoc compiler does... such as not requiring an unnecessary package definition in the proto file and thus generating a full python package containing lots of erroneous google information generated throughout the files, like google copyright statements and a readme talking about google cloud platform projects....

Describe alternatives you've considered

  • Generating the code then just heavily refactoring it to make it work. Defeats the purpose of autogeneration
  • Using the existing protoc python generator. If I was happy with it, I wouldn't have looked for alternatives

Additional context

  • If this is meant for just generating google apis... thats fine... it should just say so though. The project readme currently implies this can be used to generate grpc service code... but it seems to currently be too closely coupled to its use generating google api client code.

    This is a generator for API client libraries for APIs specified by protocol buffers, such as those inside Google. It takes a protocol buffer (with particular annotations) and uses it to generate a client library.

@xxgreg
Copy link

xxgreg commented Mar 5, 2024

FWIW I wrote a code generator which generates idiomatic python dataclasses which wrap the official protobuf python objects. I've been successfully using this for a project. But don't have time to maintain if officially. https://github.com/xxgreg/python-protodc

I use this to generate protojson requests which are used to communicate with a ConnectRPC service.

I'd definitely appreciate a supported official tool which works with proto-plus-python, as then I wouldn't need to continue maintaining this code.

@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants