Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field name in generated sample for datastream_v1 #2017

Open
ohmayr opened this issue Apr 24, 2024 · 0 comments
Open

Missing field name in generated sample for datastream_v1 #2017

ohmayr opened this issue Apr 24, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Apr 24, 2024

The generated sample for datastream_v1 does not specify name as a required field which is needed to specify the project name. See the documentation: https://cloud.google.com/python/docs/reference/datastream/latest/google.cloud.datastream_v1.services.datastream.DatastreamClient#google_cloud_datastream_v1_services_datastream_DatastreamClient_update_stream.

The proto file also mentions that field to be an output only field and does not specify it to be a required field: https://github.com/googleapis/googleapis/blob/master/google/cloud/datastream/v1/datastream_resources.proto#L791.

The request to update the stream results in an error if the name field is not populated as part of the request. See: #1786

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 24, 2024
@ohmayr ohmayr added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants