Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showcase to golden files #2022

Open
parthea opened this issue May 2, 2024 · 0 comments
Open

Add showcase to golden files #2022

parthea opened this issue May 2, 2024 · 0 comments
Assignees
@ohmayr
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@parthea
Copy link
Contributor

parthea commented May 2, 2024

See #1991 which was an attempt to add showcase to golden files but is blocked on #1993. It would be helpful to have showcase in golden files so that we can preview the impact that generator changes have on the showcase client. As an example, this would address the issue in #1999 (comment)
@parthea parthea added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 2, 2024
@parthea parthea mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @ohmayr