Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting certain specialized tests out of garbage #408

Open
dazuma opened this issue Apr 10, 2020 · 1 comment
Open

Consider splitting certain specialized tests out of garbage #408

dazuma opened this issue Apr 10, 2020 · 1 comment
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@dazuma
Copy link
Member

dazuma commented Apr 10, 2020

Garbage was intended as a kitchen sink test, a dumping ground for stuff. But it's also gotten a bit large and difficult to understand, especially for "cross-cutting" features such as resource annotations. Consider breaking out certain features into separate tests (as the grpc service config has been separated) for better clarity. We do need to balance this against other concerns, though, e.g. separate tests will take longer to run than a combined test.

@dazuma dazuma added the type: cleanup An internal cleanup or hygiene concern. label Apr 10, 2020
@dazuma
Copy link
Member Author

dazuma commented Apr 14, 2020

@viacheslav-rostovtsev I opened this a few days ago. Feel free to comment here (or take this issue yourself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant