Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct pattern variables so they conform to snake case #894

Open
dazuma opened this issue Jan 5, 2023 · 0 comments
Open

Correct pattern variables so they conform to snake case #894

dazuma opened this issue Jan 5, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dazuma
Copy link
Member

dazuma commented Jan 5, 2023

AIP 123 specifies that pattern variables in resource path patterns MUST be snake case (e.g. cannot contain capital letters as you'd find in camel case). However, there are known violations in the proto corpus (e.g. in dataplex v1). We should provide some correction in the generator.
@dazuma dazuma added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 5, 2023
@dazuma dazuma mentioned this issue Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dazuma